Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/internal/unknown_set.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const FunctionResultSet& EmptyFunctionResultSet();

struct UnknownSetAccess;

class UnknownSet final {
class ABSL_ATTRIBUTE_TRIVIAL_ABI UnknownSet final {
private:
using Rep = UnknownSetRep;

Expand Down
3 changes: 2 additions & 1 deletion common/value.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ namespace cel {
// a known but invalid state. Any attempt to use it from then on, without
// assigning another type, is undefined behavior. In debug builds, we do our
// best to fail.
class Value final : private common_internal::ValueMixin<Value> {
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI Value final
: private common_internal::ValueMixin<Value> {
public:
// Returns an appropriate `Value` for the dynamic protobuf enum. For open
// enums, returns `cel::IntValue`. For closed enums, returns `cel::ErrorValue`
Expand Down
3 changes: 2 additions & 1 deletion common/values/bytes_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ absl::string_view LegacyBytesValue(const BytesValue& value, bool stable,
} // namespace common_internal

// `BytesValue` represents values of the primitive `bytes` type.
class BytesValue final : private common_internal::ValueMixin<BytesValue> {
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI BytesValue final
: private common_internal::ValueMixin<BytesValue> {
public:
static constexpr ValueKind kKind = ValueKind::kBytes;

Expand Down
3 changes: 2 additions & 1 deletion common/values/string_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ absl::string_view LegacyStringValue(const StringValue& value, bool stable,
} // namespace common_internal

// `StringValue` represents values of the primitive `string` type.
class StringValue final : private common_internal::ValueMixin<StringValue> {
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI StringValue final
: private common_internal::ValueMixin<StringValue> {
public:
static constexpr ValueKind kKind = ValueKind::kString;

Expand Down
3 changes: 2 additions & 1 deletion common/values/unknown_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class Value;
class UnknownValue;

// `UnknownValue` represents values of the primitive `duration` type.
class UnknownValue final : private common_internal::ValueMixin<UnknownValue> {
class ABSL_ATTRIBUTE_TRIVIAL_ABI UnknownValue final
: private common_internal::ValueMixin<UnknownValue> {
public:
static constexpr ValueKind kKind = ValueKind::kUnknown;

Expand Down
10 changes: 5 additions & 5 deletions common/values/values.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ class ValueInterface;
class ListValueInterface;
class StructValueInterface;

class Value;
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI Value;
class BoolValue;
class BytesValue;
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI BytesValue;
class DoubleValue;
class DurationValue;
class ABSL_ATTRIBUTE_TRIVIAL_ABI ErrorValue;
Expand All @@ -62,12 +62,12 @@ class MapValue;
class NullValue;
class OpaqueValue;
class OptionalValue;
class StringValue;
class CEL_COMMON_INTERNAL_VALUE_VARIANT_TRIVIAL_ABI StringValue;
class StructValue;
class TimestampValue;
class TypeValue;
class UintValue;
class UnknownValue;
class ABSL_ATTRIBUTE_TRIVIAL_ABI UnknownValue;
class ParsedMessageValue;
class ParsedMapFieldValue;
class ParsedRepeatedFieldValue;
Expand Down Expand Up @@ -203,7 +203,7 @@ using ListValueForEach2Callback =
absl::FunctionRef<absl::StatusOr<bool>(size_t, const Value&)>;

template <typename Base>
class ValueMixin {
class ABSL_ATTRIBUTE_TRIVIAL_ABI ValueMixin {
public:
absl::StatusOr<Value> Equal(
const Value& other,
Expand Down
Loading