fix(lana): follow-up fixes for the Salesforce Services migration - #969
Merged
Conversation
ApexLogService.listLogs requires an explicit limit, and the migration passed none, so the picker showed 25 logs. The replaced LogService query set no LIMIT and returned a full Tooling API page, so request 2000 to match.
deactivate() imported the services module to dispose it, so every window close pulled in a 129 KB chunk even when no log was ever retrieved. Register disposal when the retrieve command first loads the module instead.
The migration awaited the log body before creating the panel and then passed that body to the webview, so a slow retrieve showed no UI and a 50 MB log was copied across the webview message channel instead of streamed from disk. Hand the retrieve to createView as its beforeSendLog promise, and resolve that promise with the body only when the cache write failed. A failed write no longer records a log path that does not exist, and a rejected retrieve now reports an error instead of leaving the webview on its loading state.
Review tracking notes do not belong in the shipped repository.
Collaborator
Author
|
@peternhale This is a follow up to #951 whoch I just merged if you wouldnt mind taking a look |
peternhale
approved these changes
Aug 28, 2026
lcottercertinia
previously approved these changes
Sep 1, 2026
peternhale
approved these changes
Sep 1, 2026
# Conflicts: # lana/src/commands/LogView.ts # lana/src/commands/RetrieveLogFile.ts # lana/src/commands/__tests__/RetrieveLogFile.test.ts
lcottercertinia
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #951.
ApexLogService.listLogsneeds an explicit limit and the migration passed none, so the picker showed 25 logs.deactivate()imported the services module to dispose it, so every window close pulled in a 129 KB chunk even when no log was retrieved.docs/pr-951-952-review-findings.md.1982 tests pass; type check, lint and format are clean.