Complete supervised recovery and restart shutdown - #81
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protected recovery could stop its own supervisor and wait forever. A failed initial spawn in a restarted generation could also end supervision early, leave retry budget unused, and never complete the actor exit.
Treat the supervisor as a self-stop caller. The shutdown owner waits for its cleanup and reports cleanup defects. After a restarted generation fails during startup, read its recorded exit and apply the existing retry policy.
Full local gate:383 tests847 assertions,types,lint,format,build,and examples. Real actor tests cover protected self-stop, cleanup waiting and defects, retry exhaustion, and successful recovery on the third startup. A patch changeset records both fixes.
Two Counsel rounds are complete. Neither review found a blocker in the final change.