Fixed process_select and file_select time ranges on Windows - #6298
Open
larsewi wants to merge 1 commit into
Open
Fixed process_select and file_select time ranges on Windows#6298larsewi wants to merge 1 commit into
larsewi wants to merge 1 commit into
Conversation
ttime_range, stime_range, ctime, atime and mtime store their bounds in time_t, but parsed them through a (long *) cast. On Windows, long is narrower than time_t. Hence, only the lower half of each bound was written and the rest kept whatever garbage value the struct initializer left there. This caused the bounds to come out as large negative numbers and ttime_range matched no processes at all. Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
larsewi
added
the
cherry-pick?
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14514/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14514/ |
| split = SplitString(intrange, ','); | ||
|
|
||
| sscanf(split->name, "%ld", &lmin); | ||
| sscanf(split->name, "%" SCNd64, &lmin); |
Contributor
There was a problem hiding this comment.
Do you need to check if this format is supported with autotools?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ttime_range, stime_range, ctime, atime and mtime store their bounds in time_t, but parsed them through a (long *) cast. On Windows, long is narrower than time_t. Hence, only the lower half of each bound was written and the rest kept whatever garbage value the struct initializer left there. This caused the bounds to come out as large negative numbers and ttime_range matched no processes at all.