CFE-3293: make callers declare intent when reading a variable - #6304
Open
nickanderson wants to merge 1 commit into
Open
CFE-3293: make callers declare intent when reading a variable#6304nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
EvalContextVariableGet() always returned the plaintext value, so a caller had no way to ask for a secret-tagged variable to be redacted. Adds a get_secret parameter and *Plaintext wrappers, and moves every existing caller onto the plaintext form. No behaviour change: every call site asks for plaintext, exactly as before. Ticket: CFE-3293 Changelog: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvalContextVariableGet()always returned the plaintext value, so a caller had noway to ask for a secret-tagged variable to be redacted. This adds a
get_secretparameter, plus
EvalContextVariableGetPlaintext()and friends, and moves all 20existing call sites onto the plaintext form.
No behaviour change: every call site asks for plaintext, exactly as before. It is
the groundwork for the CFE-3294 leak fixes, which switch selected sites over.