fix: log actual interval for materialized views refresh schedule - #452
Open
erensh27 wants to merge 1 commit into
Open
fix: log actual interval for materialized views refresh schedule#452erensh27 wants to merge 1 commit into
erensh27 wants to merge 1 commit into
Conversation
… views schedule Signed-off-by: abhinav <244986440+erensh27@users.noreply.github.com>
MoralCode
requested changes
Aug 9, 2026
MoralCode
left a comment
MoralCode
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution!
Small amount of feedback, but overall I like that this is a small, very focused PR!
| mat_views_interval = int(config.get_value('Celery', 'refresh_materialized_views_interval_in_days')) | ||
| if mat_views_interval > 0: | ||
| logger.info(f"Scheduling refresh materialized view every night at 1am CDT") | ||
| logger.info(f"Scheduling refresh materialized view every {mat_views_interval} days (interval starts relative to Augur process start, not a fixed time)") |
Contributor
There was a problem hiding this comment.
Augur is the name of an older predecessor to this project, CollectOSS is the current name.
That said, I would suggest removing the name entirely as way to resolve this - potentially by reducing the verbosity of the language to just say "N days relative to program start"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refresh_materialized_views_interval_in_daysrelative to process start. The log now reports the actual configured interval days instead of the misleading hardcoded time/timezone.This PR fixes #126
Notes for Reviewers
Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below: