feat(groups): add active group switcher by chiptus · Pull Request #273 · chiptus/UpLine

chiptus · 2026-07-31T08:27:53Z

Adds a persistent header switcher (Everyone + your groups) that sets the Active Group everywhere, and retires the Artists-tab-only group filter in favor of a two-state Vote Perspective toggle built on a shared, tested vote-scope resolver.
Selecting a group in the header re-scores and re-sorts the Artists tab immediately, without a reload.

Closes #124

Verification

Sign in as a user in 2+ groups; open the header switcher, pick a group, and confirm the button updates to that group's name immediately (no reload).
On the Artists tab, with an Active Group set, confirm the Vote Perspective toggle defaults to the group and toggling to Everyone re-sorts/re-scores sets without hiding any.
Sign in as a user in zero groups; confirm the header still shows the "Create/Join a Group" CTA and the Artists tab has no Vote Perspective toggle (always Everyone).
pnpm test passes, including new src/lib/voteScope.test.ts covering Everyone/Me/Group scopes, a member vs. non-member group, no votes, and votes only from outside the group.
pnpm run typecheck and pnpm run lint pass.

Generated by Claude Code

qodo-code-review · 2026-07-31T08:27:58Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

vercel · 2026-07-31T08:27:58Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
upline	Ready	Preview	Aug 14, 2026 3:59pm

Copilot

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

github-actions · 2026-08-01T13:50:12Z

Playwright test results

50 passed

Details

50 tests across 14 suites
1 minute, 7 seconds
5193d1b

github-actions · 2026-08-01T14:04:58Z

Deploy → staging — workflow run
Last updated: 2026-08-14 15:59:14 UTC

❌ DB migrations failed
⏭️ Edge functions skipped (no changes)

⚠️ Migration failed on staging. This often means migration history drift — another PR applied migrations that aren't in this branch. To recover, you may need to reset and re-seed staging:
supabase link --project-ref <STAGING_PROJECT_REF>
supabase db reset --linked    # wipes staging data
pnpm run db:sync:staging      # re-sync anonymized prod data
Then re-run this workflow.

chiptus · 2026-08-01T14:05:55Z

The migrate / Push migrations (staging) failure isn't caused by the new migration in this PR (20260801140000_add_active_group_selected_to_profiles.sql) — its timestamp is correctly ordered after everything else. The actual error from the job log:

Found local migration files to be inserted before the last migration on remote database.
Rerun the command with --include-all flag to apply these migrations:
supabase/migrations/20260728000000_add_votes_user_id_profiles_fkey.sql

This means staging is missing 20260728000000_add_votes_user_id_profiles_fkey.sql even though later migrations were already applied — pre-existing history drift unrelated to this branch's changes. This is the first commit on this PR to touch supabase/migrations/, so it's the first time the migrate check has run here.

The auto-generated deploy-status comment on this thread suggests supabase db reset --linked to recover, but that wipes staging data — I'm not running that from this session per repo policy (CLAUDE.md: never run supabase db push / db reset). Resolving the drift needs a human decision on the staging project. Happy to push --include-all myself if that's the intended fix and someone confirms it's safe for staging's current state.

Generated by Claude Code

Deriving activeGroupId from the header's transient current scope hid the toggle whenever a user with an Active Group switched away from "group". Also seed the initial perspective from current per ADR 0005 instead of hardcoding "group". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Replace hand-rolled <button> + manual state classes with the shadcn ToggleGroup pattern already used by VotePerspectiveToggle for the same single-select choice shape. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Decompose FilteredSetsPanel.tsx (154 lines, four mixed concerns) into AuthedFilteredSetsPanel/GroupScopedSetsPanel/SetsPanelContent, matching the earlier ActiveGroupSwitcher/ScopeMenuBody split. This also removes the duplicated "everyone" SetsPanelContent call between the anonymous and authed-non-group branches. Also collapse useSetActiveGroupMutation/useSetActiveScopeMutation into a shared useProfileFieldMutation, and dedupe the ToggleGroupItem className repeated in ActiveGroupSetting/ActiveScopeSetting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

ActiveGroupSwitcher.tsx, ScopeMenuBody.tsx, and scopeDisplay.ts are used exclusively by the group switcher, so group them together instead of leaving them loose alongside unrelated AppHeader files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

chiptus · 2026-08-14T14:21:08Z

+  children: ReactNode;
+}) {
+  const { profile } = useAuth();
+  const { data: groups = [], isLoading } = useQuery(userGroupsQuery(userId));


Why don't we use suspense?

chiptus · 2026-08-14T14:23:55Z

+    activeGroupId,
+    pinned,
+    current,
+    selectScope,


Why don't we use one "selects cope" fn that has pinned boolean? Instead of two?

column/value/errorMessage now travel as mutate() arguments instead of useProfileFieldMutation generics, so ActiveScopeContext only needs one mutation instance for both active_group_id and active_scope instead of two. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

SignInRequired has two callers (Groups, Settings) with different copy; a groups-specific default was wrong for the other one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

ActiveGroupSetting/ActiveScopeSetting used the shared className identically on a ToggleGroupItem; encapsulate that as a SettingsToggleItem component instead of exporting a bare string. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

20260814140000 added active_group_selected only for the very next migration to drop it — both land in the same unmerged PR, so fold the net-zero column into the active_scope migration directly instead of shipping a column that's never actually used. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hH41h18hKSvYxWAw17nhd

Copilot AI review requested due to automatic review settings July 31, 2026 08:27

Copilot started reviewing on behalf of chiptus July 31, 2026 08:28 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

chiptus force-pushed the claude/implement-124-f9vl65 branch from ea31a03 to 4ccba62 Compare July 31, 2026 11:43

vercel Bot deployed to Preview July 31, 2026 11:44 View deployment

chiptus force-pushed the claude/implement-124-f9vl65 branch from 4ccba62 to afe4235 Compare July 31, 2026 12:50

vercel Bot deployed to Preview July 31, 2026 12:50 View deployment

vercel Bot deployed to Preview July 31, 2026 14:04 View deployment

chiptus force-pushed the claude/implement-124-f9vl65 branch from e842a09 to 44b4567 Compare August 1, 2026 13:44

vercel Bot deployed to Preview August 1, 2026 13:45 View deployment

chiptus commented Aug 1, 2026

View reviewed changes

Comment thread src/components/layout/AppHeader/GroupsIndicator.tsx Outdated

Comment thread src/lib/voteScope.test.ts

Comment thread src/lib/voteScope.test.ts Outdated

vercel Bot deployed to Preview August 1, 2026 13:55 View deployment

chiptus had a problem deploying to staging August 1, 2026 14:04 — with GitHub Actions Failure

vercel Bot deployed to Preview August 1, 2026 14:04 View deployment

chiptus had a problem deploying to staging August 1, 2026 14:09 — with GitHub Actions Failure

vercel Bot deployed to Preview August 1, 2026 14:09 View deployment

chiptus had a problem deploying to staging August 1, 2026 15:04 — with GitHub Actions Failure

vercel Bot deployed to Preview August 1, 2026 15:05 View deployment

chiptus had a problem deploying to staging August 1, 2026 15:06 — with GitHub Actions Failure

vercel Bot deployed to Preview August 1, 2026 15:06 View deployment

chiptus force-pushed the claude/implement-124-f9vl65 branch from 7accc6c to a623ddb Compare August 4, 2026 05:38

chiptus had a problem deploying to staging August 4, 2026 05:38 — with GitHub Actions Failure

vercel Bot deployed to Preview August 4, 2026 05:39 View deployment

chiptus had a problem deploying to staging August 7, 2026 18:35 — with GitHub Actions Failure

vercel Bot deployed to Preview August 7, 2026 18:35 View deployment

chiptus deployed to staging August 14, 2026 05:30 — with GitHub Actions Active

vercel Bot deployed to Preview August 14, 2026 05:31 View deployment

remove comments

115ee17

chiptus deployed to staging August 14, 2026 06:07 — with GitHub Actions Active

vercel Bot deployed to Preview August 14, 2026 06:07 View deployment

chiptus and others added 2 commits August 14, 2026 09:15

refactor: use ToggleGroup for Active group/scope settings

9954b9e

Replace hand-rolled <button> + manual state classes with the shadcn ToggleGroup pattern already used by VotePerspectiveToggle for the same single-select choice shape. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

chiptus deployed to staging August 14, 2026 07:21 — with GitHub Actions Active

vercel Bot deployed to Preview August 14, 2026 07:21 View deployment

chiptus deployed to staging August 14, 2026 08:42 — with GitHub Actions Active