Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the existing handler.hadError check in SigningHandler.modify() immediately before move() and addToDatabase(), after the signing-option branch, so any recorded signing failure throws before either persistence operation. Issue #704 reports that custom-entitlement signing can fail inside zsign while Feather saves an invalid app as signed; the stated acceptable outcome includes reporting the signing failure.
On the pre-fix revision, stop in SigningHandler.modify() immediately before move(), set handler.hadError to SigningFileHandlerError.signFailed, and continue: verify that an error is reported but a new Signed directory and database record are incorrectly created. Repeat after the fix with the breakpoint before the relocated error check: require an error, no new Signed directory or record, temporary work-directory cleanup, and retention of the imported source. Use a disposable app/certificate and record baseline directory and library contents before each run; Repeat the failure case with automatic installation and delete-source-after-sign enabled: neither success action may run. Previously signed unrelated apps must remain intact.
Fixes #704