refactor(ui): name the Mosaic UserButton layers for their MVC roles - #9446
Open
alexcarpenter wants to merge 2 commits into
Open
refactor(ui): name the Mosaic UserButton layers for their MVC roles#9446alexcarpenter wants to merge 2 commits into
alexcarpenter wants to merge 2 commits into
Conversation
The hook derives Clerk's resources into the shapes the view renders. That is a model, not a controller; the controller is the connected component that binds it to the view.
It holds the interaction state and binds the model to the view, so it is the controller. The filename now says so.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 85c2429 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useUserButtonControllerderives Clerk's resources into the shapes the view renders. That is a model, not a controller. The connected component is the controller: it holds the interaction state and binds the model to the view.user-button.controller.tsxuser-button.model.tsxuser-button.tsxuser-button.controller.tsxuser-button.view.tsxuseUserButtonControllerbecomesuseUserButtonModel,UserButtonControllerbecomesUserButtonModel, andUserButtonControllerOptionsbecomesUserButtonModelOptions. Comments that named the layers follow.Renames only. No behavior, no logic, and no public export changes;
UserButtonis not barrel-exported on this branch yet.Checklist
Type of change