Splitting sdk-test out of Test Suite - #5854
Conversation
Signed-off-by: Jason Larabie <jason@clockworklabs.io>
This reverts commit 73d5940.
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
I'm happy with the current structure. The build times are still rather high for the sdk artifacts, however I think this can be improved with an up-to-date runner image with warmed cache. I also think there are caching improvements we can make for the c++ sdk and modules by baking those compilation units into the runner image. So ultimately I think we can reduce those build times substantially with infra-side changes.
| SDK_TEST_CLIENT_DIR: sdk-test-clients/native | ||
| steps: &sdk-test-partition-steps | ||
| - *set-cargo-target-dir | ||
| - *configure-sccache |
There was a problem hiding this comment.
Do these tests compile anything now?
There was a problem hiding this comment.
No this was unnecessary and cleaned up
| INSTALLED_WASM_BINDGEN_VERSION="$(wasm-bindgen --version 2>/dev/null | awk '{print $2}' || true)" | ||
| if [ "${INSTALLED_WASM_BINDGEN_VERSION}" != "${REQUIRED_WASM_BINDGEN_VERSION}" ]; then | ||
| cargo install --locked --force wasm-bindgen-cli --version "${REQUIRED_WASM_BINDGEN_VERSION}" | ||
| fi |
There was a problem hiding this comment.
It looks like this block was removed entirely. Was that intentional?
There was a problem hiding this comment.
This was moved down into the browser client via sdk_test_prepare_native -> sdk-test-prepare-steps with an if block to only use it during browser mode.
2 participants
Description of Changes
First step to #5839 splitting out the SDK tests and partition:
cargo ci sdk-testscommand for local SDK test executionAPI and ABI breaking changes
No breaking changes - only tests
Rollback safety impact
n/a
Expected complexity level and risk
2 - Splitting up requires CI work and mucking with test setup for preparing clients
Testing