Add SAP licence support - #487
Open
fabi200123 wants to merge 1 commit into
Open
Conversation
Dany9966
approved these changes
Aug 6, 2026
Dany9966
reviewed
Aug 6, 2026
fabi200123
force-pushed
the
add-sap-support
branch
2 times, most recently
from
August 6, 2026 13:59
a0efa42 to
ac3a8b7
Compare
Dany9966
requested changes
Aug 7, 2026
| @@ -556,6 +554,6 @@ class ChecksumMismatch(CoriolisException): | |||
| class MigrationLicenceFulfilledException(Invalid): | |||
| message = ( | |||
| "The Live Migration operation with ID '%(action_id)s' (licensing " | |||
Contributor
There was a problem hiding this comment.
I would also replace this ("Live Migration") with scenario, just in case there will be multiple scenarios that can throw 403.
I'd add something like this:
"The %s operation with ID .... " % transfer.scenario.replace('_', ' ').title()
Contributor
Author
There was a problem hiding this comment.
In this case, also renamed it to LicenceReservationFulfilledException
fabi200123
force-pushed
the
add-sap-support
branch
from
August 7, 2026 10:47
ac3a8b7 to
7723619
Compare
fabi200123
force-pushed
the
add-sap-support
branch
from
August 7, 2026 14:19
7723619 to
5fe4da0
Compare
Dany9966
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
sap_migration,sap_replicaandsap_libvirt(endpoint type)SCENARIO_TYPE_TO_LICENSING_RESERVATION_MAP: a newENDPOINT_TYPE_TO_LICENSING_RESERVATION_OVERRIDESmap and_get_reservation_typehelper resolve the reservation type based on the destination endpoint type, falling back to the scenario-based map. Transfers targetingsap_libvirtendpoints get SAP reservation types_create_reservation_for_transfercallsNote:
MigrationLicenceFulfilledExceptionis no longer raised by the conductor, since the equivalent check is now enforced server-side. The conductor no longer performs the fulfilled-migration check itself.