Skip to content

rename sourcingkit to import from s3 - #33341

Merged
deannalam merged 1 commit into
cloudflare:productionfrom
dochne:production
Sep 10, 2026
Merged

rename sourcingkit to import from s3#33341
deannalam merged 1 commit into
cloudflare:productionfrom
dochne:production

Conversation

@dochne

@dochne dochne commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This renames Cloudflare Images SourcingKit to "Import from S3".

It also updates our documentation to account for our recent UI refresh of this feature.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@dochne
dochne requested review from a team, deannalam and renandincer as code owners September 9, 2026 12:27
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review

💡 2 suggestions found in commit b5c97d1.

👉 Fix in your agent 👈
Fix the following review findings in PR #33341 (https://github.com/cloudflare/cloudflare-docs/pull/33341).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (2)

#### CR-a1a4d0013e8e · Contradictory storage-class claim
- **File:** `src/content/docs/images/storage/upload-images/import-from-s3/index.mdx` line 19
- **Issue:** Line 19 states Import from S3 "skips images in archival storage classes", but line 21 explicitly says Glacier Instant Retrieval is not skipped even though the linked AWS page (https://aws.amazon.com/s3/storage-classes/#Archive) categorizes Glacier Instant Retrieval as an archive storage class, so the blanket claim contradicts the exception stated two lines below.
- **Fix:** Qualify line 19 to name the specific classes that are skipped (e.g., "S3 Glacier Flexible Retrieval and S3 Glacier Deep Archive") so it does not conflict with the Glacier Instant Retrieval exception in line 21.

#### CR-5224526e5f1a · Missing procedural step
- **File:** `src/content/docs/images/storage/upload-images/import-from-s3/credentials.mdx` line 39
- **Issue:** The final paragraph says the reader can now use the Access Key ID and Secret Access Key to create a source, but the preceding steps only create a user and attach the policy — AWS does not generate an access key pair during user creation, so a reader following the steps has no credentials to use.
- **Fix:** Add a step instructing the reader to create an access key for the user (IAM console → user → Security credentials → Create access key) before the closing paragraph.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (2)
File Issue
images/storage/upload-images/import-from-s3/index.mdx line 19 Contradictory storage-class claim — Line 19 states Import from S3 "skips images in archival storage classes", but line 21 explicitly says Glacier Instant Retrieval is not skipped even though the linked AWS page (https://aws.amazon.com/s3/storage-classes/#Archive) categorizes Glacier Instant Retrieval as an archive storage class, so the blanket claim contradicts the exception stated two lines below. Fix: Qualify line 19 to name the specific classes that are skipped (e.g., "S3 Glacier Flexible Retrieval and S3 Glacier Deep Archive") so it does not conflict with the Glacier Instant Retrieval exception in line 21.
images/storage/upload-images/import-from-s3/credentials.mdx line 39 Missing procedural step — The final paragraph says the reader can now use the Access Key ID and Secret Access Key to create a source, but the preceding steps only create a user and attach the policy — AWS does not generate an access key pair during user creation, so a reader following the steps has no credentials to use. Fix: Add a step instructing the reader to create an access key for the user (IAM console → user → Security credentials → Create access key) before the closing paragraph.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@deannalam
deannalam merged commit 4629471 into cloudflare:production Sep 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:images Related to Image Resizing product size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants