rename sourcingkit to import from s3 - #33341
Merged
Merged
Conversation
dochne
requested review from
a team,
deannalam and
renandincer
as code owners
September 9, 2026 12:27
Contributor
Review💡 2 suggestions found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33341 (https://github.com/cloudflare/cloudflare-docs/pull/33341).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (2)
#### CR-a1a4d0013e8e · Contradictory storage-class claim
- **File:** `src/content/docs/images/storage/upload-images/import-from-s3/index.mdx` line 19
- **Issue:** Line 19 states Import from S3 "skips images in archival storage classes", but line 21 explicitly says Glacier Instant Retrieval is not skipped even though the linked AWS page (https://aws.amazon.com/s3/storage-classes/#Archive) categorizes Glacier Instant Retrieval as an archive storage class, so the blanket claim contradicts the exception stated two lines below.
- **Fix:** Qualify line 19 to name the specific classes that are skipped (e.g., "S3 Glacier Flexible Retrieval and S3 Glacier Deep Archive") so it does not conflict with the Glacier Instant Retrieval exception in line 21.
#### CR-5224526e5f1a · Missing procedural step
- **File:** `src/content/docs/images/storage/upload-images/import-from-s3/credentials.mdx` line 39
- **Issue:** The final paragraph says the reader can now use the Access Key ID and Secret Access Key to create a source, but the preceding steps only create a user and attach the policy — AWS does not generate an access key pair during user creation, so a reader following the steps has no credentials to use.
- **Fix:** Add a step instructing the reader to create an access key for the user (IAM console → user → Security credentials → Create access key) before the closing paragraph.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (2)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
nils-ohlmeier
approved these changes
Sep 10, 2026
mglewis
approved these changes
Sep 10, 2026
deannalam
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This renames Cloudflare Images SourcingKit to "Import from S3".
It also updates our documentation to account for our recent UI refresh of this feature.
Screenshots (optional)
Documentation checklist