Support IP_TRANSPARENT on listening sockets - #987
Open
torinnd wants to merge 1 commit into
Open
Conversation
Add a Linux-only ip_transparent option to TcpSocketOptions. Pingora applies IP_TRANSPARENT for IPv4 listeners or IPV6_TRANSPARENT for IPv6 listeners before bind, preserving Pingora's ownership of the listening fd and its graceful-transfer path. Enabling the option requires CAP_NET_ADMIN or CAP_NET_RAW and the corresponding transparent routing configuration. Restored listener fds keep the option state inherited from the old process. The unprivileged test exercises disabling the option for IPv4 and, when IPv6 sockets are available, IPv6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Linux-only
ip_transparentoption toTcpSocketOptions. Pingora appliesIP_TRANSPARENTto IPv4 listeners andIPV6_TRANSPARENTto IPv6 listeners beforebind().Transparent proxy listeners need this option before binding non-local addresses. Exposing it through
TcpSocketOptionslets Pingora retain ownership of the listener and participate in its normal fd-transfer lifecycle, rather than requiring the application to bind the socket itself.Enabling the option requires
CAP_NET_ADMINorCAP_NET_RAW, along with the corresponding routing configuration. Inherited listener fds retain their existing socket options, so configuration changes apply when Pingora binds a new listener.The unprivileged test exercises the disabled setting for IPv4 and, where IPv6 sockets are available, IPv6. Testing the enabled setting would require privileged CI.