Add claude config - #269
s-yonkov-yonkov wants to merge 2 commits into
Conversation
Yavor16
left a comment
Yavor16
left a comment
There was a problem hiding this comment.
I see no mention that there must be Jira backlog in the commit description. Add also don't-s section. like don't to relases or edit the version files. something like that
| | `clients/mtaclient_v2/` | go-openapi generated MTA REST client (API v2) | | ||
| | `clients/mtaclient/fakes/` | Fake v1 client builder for tests | | ||
| | `clients/mtaclient_v2/fakes/` | Fake v2 client builder for tests | | ||
| | `clients/restclient/` | Lower-level REST client (file upload, operations polling) | |
There was a problem hiding this comment.
why was file upload and operations polling mentioned for the clients/restclient/ folder? From what I have seen isn't its purpose to purge configuration entries and to fetch csrf-tokens?
|
|
||
| A few behaviors are non-obvious from the package layout — check the referenced files before touching them: | ||
|
|
||
| - **File upload** (`util/file_splitter.go`) — MTAR archives are split into at most **50 chunks** |
There was a problem hiding this comment.
shouldn't we also mention here the file which is actually responsible for the file uploading - file_uploader and not only the one already stated, which is only for splitting into chunks?
|
|
||
| ## Package Layout | ||
|
|
||
| | Package | Purpose | |
There was a problem hiding this comment.
why was the log folder missed?
| - **Ginkgo v1 + Gomega** for tests — suites bootstrap via `go test` (`RunSpecs` in `*_suite_test.go`) | ||
|
|
||
| ## Package Layout | ||
|
|
There was a problem hiding this comment.
also why was the configuration folder missed? wouldn't this be helpful when for example a new environment variables must be added or the already existing ones need changes?
3 participants
No description provided.