feat: Removed Column Index lookup - #2593
Open
bbernays wants to merge 2 commits into
Open
Conversation
Member
|
My suggestion in #2592 was wrong. To cover it, make // schema/resource.go
type Resource struct {
// ...
columnIndexHint int
}
func (r *Resource) Set(columnName string, value any) error {
index := r.columnIndexHint
if index < 0 || index >= len(r.data) || r.Table.Columns[index].Name != columnName {
index = r.Table.Columns.Index(columnName)
if index == -1 {
panic(columnName + " column not found")
}
}
// existing r.data[index].Set(value) + panic on error
}
func (r *Resource) setColumnIndexHint(i int) { r.columnIndexHint = i }
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified implementation of #2592 that handles the main call site. In the future we can look at implementing a more fully implemented cache