fix: treat optional identifier quoting as equivalent in table diffs - #254
Open
cliff-openai wants to merge 1 commit into
Open
fix: treat optional identifier quoting as equivalent in table diffs#254cliff-openai wants to merge 1 commit into
cliff-openai wants to merge 1 commit into
Conversation
Spanner may return unquoted identifiers in live DDL even when the source schema quotes them. Comparing the rendered primary key then rejects a no-op migration as an unsupported key change; comparing column names literally can also manufacture drops and additions. Compare the identifier represented by each key and column independently of optional backticks while preserving the original spelling when rendering DDL. Keep key order and direction checks intact, and cover the no-op and genuine column-change cases.
cliff-openai
force-pushed
the
cliff/fix-quoted-identifier-diff
branch
from
September 4, 2026 16:44
ca6aee8 to
fc1eb72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Spanner's live DDL may omit optional backticks present in a source schema. The first schema update can succeed, but subsequent plans then fail with “Cannot change primary key” because the diff compares rendered key text. Quoted and unquoted column names can likewise appear to be different columns.
Compare primary-key parts and column definitions by their identifier values rather than optional quoting, while retaining the source spelling in generated DDL. Key order and direction remain significant, and genuine column changes still produce migrations.