You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
route every preview request through live-claim authorization, activity stamping, wake serialization, and a fresh guest dial
reject idle-hibernate settings on egress pools, which cannot resume safely
align deploy docs and audit event naming with the implemented contract
Why
Guest connection pooling let a reused preview request skip PreviewDial. If idle hibernation had already entered its transition, that request could reach the stopped connection instead of waiting for wakeResolved; non-replayable requests could fail. The narrow fix removes guest-side keep-alive reuse instead of adding connection generations or more lifecycle state.
Egress pools accepted idle-hibernate configuration even though Hibernate intentionally rejects that lane, so the setting could never provide the documented behavior.
This PR is stacked on #81 and contains one commit.
Validation
make go-test
GOLANGCI_LINT_CACHE=/tmp/sandbox-pr81-golangci-cache make go-lint
GOOS=linux|darwin GOWORK=off asl ./... across all Go modules
macOS: make lint && make test
Linux Rust container: rustfmt, clippy with -D warnings, and tests for boot/init and silkd
Squash-merged into codex/close-repo-review as 4183bb3, together with the residual this PR's config gate could not reach: the node-wide idle sweep still selected unpooled egress claims (template/checkpoint claims on the egress lane), which hibernateLocked then refused every tick. idleOnce now skips the lane outright.
No test rides that last part: hibernateLocked returns ErrNoEgressHibernate before touching any state, so a mutation test confirmed no state-level assertion can tell the two behaviours apart — the only symptom was a logged error per sweep. The invariant itself stays covered by TestEgressLaneDoesNotHibernate.
Reviewed and agreed on the preview reasoning: the pooled path bypassed Transition, which is the only serialization point between a claim and its own hibernation. Closing in favour of the squashed commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Guest connection pooling let a reused preview request skip
PreviewDial. If idle hibernation had already entered its transition, that request could reach the stopped connection instead of waiting forwakeResolved; non-replayable requests could fail. The narrow fix removes guest-side keep-alive reuse instead of adding connection generations or more lifecycle state.Egress pools accepted idle-hibernate configuration even though
Hibernateintentionally rejects that lane, so the setting could never provide the documented behavior.This PR is stacked on #81 and contains one commit.
Validation
make go-testGOLANGCI_LINT_CACHE=/tmp/sandbox-pr81-golangci-cache make go-lintGOOS=linux|darwin GOWORK=off asl ./...across all Go modulesmake lint && make test-D warnings, and tests forboot/initandsilkd