fix: gracefully handle sentry-sdk < 2.0 in telemetry - #748
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
ImportErroroccurring whencodecov-cliattempts to importget_current_scopefromsentry_sdk.scope, which is only available insentry-sdkversions 2.0 and above. The issue arises when the CLI is run in an environment withsentry-sdkv1.x installed, despitepyproject.tomlspecifyingsentry-sdk==2.*.To fix this:
sentry_sdk.get_current_scope().transactioninupload_sender.pyis now wrapped in atry/except AttributeErrorblock. This prevents a hard crash ifget_current_scopeis missing, allowing the CLI to continue execution without Sentry transaction data in such cases.opentelemetry.pyduring Sentry SDK initialization. Ifsentry-sdkversion is detected to be less than 2.0, a warning is logged, providing early diagnostic information about the environment mismatch.Fixes CLI-FW