fix: validate git service for create-report-results - #750
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
create-report-resultscommand could sendNoneas the git service to the Codecov API, resulting in a 400 Bad Request error due to API-side validation.Root Cause:
In older CLI versions (e.g., v10.4.0), when the
--git-serviceflag was not provided and the CI environment could not auto-detect the service, the PythonNonevalue forgit_servicewas directly interpolated into the API request URL as the string "None". The API would then reject this invalid service value.Solution:
An early validation guard has been added to the
create_report_results_logicfunction. If theserviceparameter isNoneor empty, it now explicitly callsvalidate_upload_service(""). This leverages the existing client-side validation logic inupload_url_validation.pyto immediately raise aclick.ClickExceptionwith a clear, user-friendly message (e.g., "Upload service is missing...") before any network request is made. This prevents invalid API calls and provides better feedback to the user.This change ensures that the CLI fails fast and informatively when the git service is missing for
create-report-results.Fixes CLI-FX