fix: strip whitespace from CODECOV_TOKEN in Authorization header - #792
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Author
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CODECOV_TOKENenvironment variable, especially when sourced from CI environments like GitHub Actions, can contain trailing newline characters (e.g.,\n\n). When this token is used to construct theAuthorizationheader in HTTP requests, therequestslibrary correctly rejects the header value due to these invalid characters, raising anInvalidHeaderexception.This fix addresses the issue by calling
.strip()on thetokenvalue in bothget_token_header()andget_token_header_or_fail()functions withincodecov_cli/helpers/request.py. This ensures that any leading or trailing whitespace, including newlines, is removed before the token is interpolated into theAuthorizationheader, preventing theInvalidHeadererror.Fixes CLI-1R
This PR was automatically generated by Sentry. You can adjust this setting at any time.