fix: resolve file paths correctly for file fixes - #794
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Author
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
FileNotFoundErroroccurring during the file fixing process incodecov_cli/services/upload/upload_collector.py.Root Cause:
Previously, the
_get_file_fixes()method would attempt to open files using paths returned bygit ls-files. These paths are relative to the repository root (network_root_folder). However, the CLI process's current working directory (CWD) is not always guaranteed to be thenetwork_root_folder. When the CWD differed,open(filename, 'r')would fail to locate the file, leading to aFileNotFoundError.Solution:
_get_file_fixes()to construct an absolute path by prependingself.network_finder.network_root_folderto thefilenamebefore attempting to open it. This ensures the file is always looked for in the correct location relative to the repository root.FileNotFoundErrorhandling to gracefully log a warning and skip applying file fixes for that particular file if it cannot be found. This prevents the entire upload process from crashing due to a missing file, similar to howUnicodeDecodeErrorandIsADirectoryErrorare handled.This fix ensures that file fixes are correctly applied in various CI environments where the CWD might not align with the repository root.
Fixes CLI-94
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.