fix: update env vars - #81
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1 ☔ View full report in Codecov by Harness. |
thomasrockhu-codecov
force-pushed
the
th/fix-update-env-vars
branch
from
September 15, 2026 01:11
035048f to
643b910
Compare
| if matches and matches.groups(): | ||
| return f"CC_{matches.groups()[0]}" | ||
|
|
||
| matcher = r'(CC_[\w_]+)' |
There was a problem hiding this comment.
nit: would we want a ^ for start of string before CC?
There was a problem hiding this comment.
I suppose it doesn't make a difference at the moment since all of the variables currently only start with CC so this would only be for defensive purposes.
Collaborator
Author
There was a problem hiding this comment.
no actually, reason being that sometimes there is whitespace before the var declaration (e.g. a tab), but this is more to catch any vars that match it
calvin-codecov
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.