fix(Input): use fr-message classes instead of fr-error/valid/info-text - #492
Merged
Merged
Conversation
The DSFR documentation recommends using .fr-message with .fr-message--error, .fr-message--valid and .fr-message--info instead of the legacy monolithic class names. The old classes caused icon misalignment on multi-line messages. Closes codegouvfr#480
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Inputcomponent was using legacy DSFR CSS classes for state messages:.fr-error-text.fr-valid-text.fr-info-textThese classes cause icon misalignment when the message spans multiple lines (see #480).
Fix
Replace with the classes recommended by the official DSFR documentation:
.fr-message .fr-message--error.fr-message .fr-message--valid.fr-message .fr-message--infoAll three modifier classes are already present in
src/fr/generatedFromCss/classNames.tsand correctly typed.Closes #480