Skip to content

chore(ci): fix the npm publish job and bump to 1.33.0 - #507

Merged
kevbarns merged 2 commits into
codegouvfr:mainfrom
kevbarns:chore/fix-npm-publish-job-and-bump-1.33.0
Aug 19, 2026
Merged

chore(ci): fix the npm publish job and bump to 1.33.0#507
kevbarns merged 2 commits into
codegouvfr:mainfrom
kevbarns:chore/fix-npm-publish-job-and-bump-1.33.0

Conversation

@kevbarns

Copy link
Copy Markdown
Collaborator

Fix the npm publish job and release 1.33.0

Two commits, to be merged after #506 so that 1.33.0 carries both.

1. The publish job has been broken since npm 12

publish_on_npm pins node 20, then runs npm install -g npm@latest. npm 12 declares
engines: {"node": "^22.22.2 || ^24.15.0 || >=26.0.0"}, so that install fails with
EBADENGINE and the job dies before ever reaching npm publish:

npm error code EBADENGINE
npm error Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error Actual:   {"npm":"10.8.2","node":"v20.20.2"}

That is why 1.32.5 has a git tag and a GitHub release but never reached npm: in
run 30816134336,
create_github_release succeeded and publish_on_npm failed, leaving latest on 1.32.4.
Any version bump would fail the same way until this is fixed.

The job moves to node 22, which is already what the test job uses.

2. Bump to 1.33.0

Minor rather than patch: #505 adds a new opt-in CLI command
(react-dsfr only-include-used-components) and a new bin entry, which is additive
public surface. No breaking change.

The release also carries the two fixes that were tagged 1.32.5 but never published
(#493 Footer categoryName as ReactNode, #501 SideMenu plain button), and, if merged
after #506, its only-include-used-icons fixes.

npm will go 1.32.4 → 1.33.0. The v1.32.5 tag stays as a release that never shipped;
npm does not require contiguous versions.

Merge order

#506 first, then this. Merged the other way round, 1.33.0 would ship without #506 and
that fix would need a 1.33.1.

`publish_on_npm` pins node 20 and then runs `npm install -g npm@latest`. npm 12
declares `engines: {"node": "^22.22.2 || ^24.15.0 || >=26.0.0"}`, so that install
fails with EBADENGINE and the job dies before `npm publish`.

This is why 1.32.5 has a git tag and a GitHub release but was never published:
in run 30816134336, `create_github_release` succeeded and `publish_on_npm`
failed, leaving npm on 1.32.4.

Bring the job to node 22, which is what the test job already uses.
Minor: only-include-used-components (codegouvfr#505) adds a new opt-in CLI command and a
new `bin` entry, which is additive public surface. Also carries the fixes that
were tagged 1.32.5 but never reached npm.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release pipeline to restore successful npm publishing (by aligning the publish job’s Node version with the repo’s Node 22 baseline) and bumps the package version for the 1.33.0 release.

Changes:

  • Bump @codegouvfr/react-dsfr version from 1.32.5 to 1.33.0.
  • Update the publish_on_npm GitHub Actions job to use Node 22 so npm install -g npm@latest no longer fails due to engine constraints.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Bumps package version to 1.33.0 for the release.
.github/workflows/ci.yaml Switches npm publish job to Node 22 to fix npm@latest installation/publish.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kevbarns kevbarns self-assigned this Aug 19, 2026
@kevbarns kevbarns changed the title chore(ci): Fix the npm publish job and bump to 1.33.0 chore(ci): fix the npm publish job and bump to 1.33.0 Aug 19, 2026

@lsagetlethias lsagetlethias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevbarns
kevbarns merged commit 621ee4a into codegouvfr:main Aug 19, 2026
6 checks passed
@kevbarns
kevbarns deleted the chore/fix-npm-publish-job-and-bump-1.33.0 branch August 19, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants