chore(ci): fix the npm publish job and bump to 1.33.0 - #507
Merged
kevbarns merged 2 commits intoAug 19, 2026
Merged
Conversation
`publish_on_npm` pins node 20 and then runs `npm install -g npm@latest`. npm 12
declares `engines: {"node": "^22.22.2 || ^24.15.0 || >=26.0.0"}`, so that install
fails with EBADENGINE and the job dies before `npm publish`.
This is why 1.32.5 has a git tag and a GitHub release but was never published:
in run 30816134336, `create_github_release` succeeded and `publish_on_npm`
failed, leaving npm on 1.32.4.
Bring the job to node 22, which is what the test job already uses.
Minor: only-include-used-components (codegouvfr#505) adds a new opt-in CLI command and a new `bin` entry, which is additive public surface. Also carries the fixes that were tagged 1.32.5 but never reached npm.
There was a problem hiding this comment.
Pull request overview
This PR updates the release pipeline to restore successful npm publishing (by aligning the publish job’s Node version with the repo’s Node 22 baseline) and bumps the package version for the 1.33.0 release.
Changes:
- Bump
@codegouvfr/react-dsfrversion from1.32.5to1.33.0. - Update the
publish_on_npmGitHub Actions job to use Node 22 sonpm install -g npm@latestno longer fails due to engine constraints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Bumps package version to 1.33.0 for the release. |
| .github/workflows/ci.yaml | Switches npm publish job to Node 22 to fix npm@latest installation/publish. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the npm publish job and release 1.33.0
Two commits, to be merged after #506 so that 1.33.0 carries both.
1. The publish job has been broken since npm 12
publish_on_npmpins node 20, then runsnpm install -g npm@latest. npm 12 declaresengines: {"node": "^22.22.2 || ^24.15.0 || >=26.0.0"}, so that install fails withEBADENGINEand the job dies before ever reachingnpm publish:That is why 1.32.5 has a git tag and a GitHub release but never reached npm: in
run 30816134336,
create_github_releasesucceeded andpublish_on_npmfailed, leavinglateston 1.32.4.Any version bump would fail the same way until this is fixed.
The job moves to node 22, which is already what the
testjob uses.2. Bump to 1.33.0
Minor rather than patch: #505 adds a new opt-in CLI command
(
react-dsfr only-include-used-components) and a newbinentry, which is additivepublic surface. No breaking change.
The release also carries the two fixes that were tagged 1.32.5 but never published
(#493 Footer
categoryNameasReactNode, #501 SideMenu plain button), and, if mergedafter #506, its
only-include-used-iconsfixes.npm will go 1.32.4 → 1.33.0. The
v1.32.5tag stays as a release that never shipped;npm does not require contiguous versions.
Merge order
#506 first, then this. Merged the other way round, 1.33.0 would ship without #506 and
that fix would need a 1.33.1.