Skip to content

refactor: Change BaseAuthToken and BaseValidator to abstract #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsonasik wants to merge 2 commits into
base: develop
Choose a base branch
from
+6 −2
Open

refactor: Change BaseAuthToken and BaseValidator to abstract #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702fcb4
refactor: Change BaseAuthToken and BaseValidator to abstract
samsonasik Sep 9, 2026
e9505ef
update namespace to detect to CodeIgniter\Shield
samsonasik Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Authentication/Passwords/BaseValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use CodeIgniter\Shield\Config\Auth as AuthConfig;

class BaseValidator
abstract class BaseValidator
{
protected ?string $error = null;
protected ?string $suggestion = null;
Expand Down
2 changes: 1 addition & 1 deletion src/Config/BaseAuthToken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use CodeIgniter\Config\BaseConfig;

class BaseAuthToken extends BaseConfig
abstract class BaseAuthToken extends BaseConfig
{
/**
* List of HMAC Encryption Keys
Expand Down
4 changes: 4 additions & 0 deletions structarmed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Boundwize\StructArmed\Architecture;
use Boundwize\StructArmed\Preset\Preset;
use Boundwize\StructArmed\Preset\Presets\Psr4Preset;
use Boundwize\StructArmed\Rule\Rules\Class_\ExtendedClassMustBeAbstractOrInstantiatedRule;
use Boundwize\StructArmed\Rule\Rules\Class_\MustBeFinalRule;

return Architecture::define()
Expand All @@ -19,6 +20,9 @@
])
->cacheDirectory(is_dir('/tmp') ? '/tmp/structarmed' : null)
->withPresets(Preset::PSR4(), Preset::CODEQUALITY())

->rule('base_classes.must_be_abstract', new ExtendedClassMustBeAbstractOrInstantiatedRule('Source', '/^CodeIgniter\\\\Shield\\\\.*Base.*$/'))

->layer('tests', __DIR__ . '/tests')
->layerPattern('Model', '/^CodeIgniter\\\\Shield\\\\.*Model$/')
->layerPattern('Controller', '/^CodeIgniter\\\\Shield\\\\Controllers\\\\.*$/')
Expand Down
Loading