chore: refactor notifications to support categories - #265
Merged
Conversation
`AppDelegate` now acts as the `UNUserNotificationCenterDelegate` directly, replacing the standalone `NotifDelegate`. This lets notification response handlers reach app state, such as the menu bar controller. Notifications now carry a category. `NotificationCategory` is `CaseIterable`, and every case is registered with the notification center on launch, so a new case cannot be forgotten at registration. No user-visible change. Groundwork for sending notifications on VPN failures (#195).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ethanndickson
changed the title
jakehwll
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppDelegatenow acts as theUNUserNotificationCenterDelegatedirectly, replacing the standaloneNotifDelegate. This lets notification response handlers reach app state, such as the menu bar controller.Notifications now carry a category.
NotificationCategoryisCaseIterable, and every case is registered with the notification center on launch, so a new case cannot be forgotten at registration.No user-visible change. Groundwork for sending notifications on VPN failures (#195).