ci: add manual release promotion to the Desktop bucket - #13
Merged
Merged
Conversation
Download and verify an existing GitHub release before uploading its artifacts without overwriting published versions. Document the required bucket IAM grant for the existing workload identity. > Xum prepared this change on behalf of @ibetitsmike. Signed-off-by: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com>
Signed-off-by: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com>
ibetitsmike
marked this pull request as ready for review
September 11, 2026 06:13
ethanndickson
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Promote an existing signed GitHub release to the bucket Coder Desktop installers already use, without rebuilding or re-signing it. The companion infrastructure PR is https://github.com/coder/gcp/pull/229.
Changes
v0.18.4.SHA256SUMS, then verify the complete manifest before GCP authentication.gs://coder-desktop/mutagen/<tag>/, with generation preconditions that refuse overwrites. Upload the checksum manifest last.The
coder-desktopbucket already exists in projectcoder-ciand is configured incoder/gcp/projects/production/coder-ci. No destination or bucket settings change is required. The uploader grant in coder/gcp#229 must be approved and deployed before this workflow can upload.Validation
actionlint, extracted Bash syntax checks and ShellCheck, andgit diff --checkpassed.v0.18.4release and verified all five payload checksums against its manifest.scripts/ci/verify_commits.sh.8f033ce8049b1e57354e91150edec3a7da70e710, including Linux, macOS, Windows, and Sidecar.No live upload was attempted. This PR authorizes no merge, infrastructure apply, state import, or release promotion.
PR delivery record
4bcbb6f857. No public report URL is available. This records the existing review, not a new review.8f033ce8049b1e57354e91150edec3a7da70e710.