🤖 fix: remove permanent transcript loading space - #4173
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ammario
added this pull request to stack #4174
September 9, 2026 02:02
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 02:03
d122081 to
069727d
Compare
Collaborator
Author
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
@codex review Rebased onto the corrected startup-recovery base. The loading UI diff is unchanged; integrated static checks, 66 UI tests, and all 7 geometry integration tests pass. |
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 02:24
069727d to
01765dd
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
@codex review Retrying after the review service reported an unknown error. The UI diff is unchanged from the previously approved revision; only the corrected lower-PR base was rebased underneath it. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Collaborator
Author
|
The earlier Codex service-error comment (5594831604) is superseded by the successful code and security reviews of the same 01765dd revision. Marking only that no-finding service error as outdated; substantive reviews remain visible. |
Collaborator
Author
|
@codex review Rebased the unchanged UI diff onto the final startup corrections. Integrated static checks and loading/scroll contracts pass; prior desktop/phone visual and geometry validation remains unchanged. |
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 02:48
01765dd to
275036c
Compare
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 275036c155
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 03:09
275036c to
fc7b543
Compare
Collaborator
Author
|
Addressed both findings:
65 hydration/scroll/story tests, 7 geometry integration tests, 3 Chromium Storybook plays, and integrated static checks pass. Production delta is +20/-23, net -3. Rebased on the latest startup fixes. |
Collaborator
Author
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 16:46
fc7b543 to
093f537
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
_Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$264.85`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=264.85 -->
<!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=264.85 -->
Reuse bulk metadata for identity admission and interrupted retry derivation, retaining the snapshot across deferred reruns. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$316.14`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=316.14 -->
Restore durable parent guidance behind restarted interactive questions without dispatching a turn. Reuse per-ID queue dedupe and settlement; preserve Stop and opt-out precedence. Validation: 1083 targeted regression tests; make static-check. Production ledger: +98/-101, net -3.
Share live/restored guidance background handoff and cancellation settlement. Reuse transient ownership for startup admission, recovery, and empty compaction checks; detach abandoned probes before deferred physical cleanup while preserving adopted sessions. Validation: 1093 tests passed across five lifecycle suites; make static-check passed. Production ledger: +83/-83, net zero.
Distinguish durable Stop/opt-out from indeterminate startup blockers and settle stopped child lifecycles before queued work is admitted. Preserve question waits, read-failure blockers, and live work. Suppress redundant nested handle drains until the complete task-stop batch settles. Simplify stale-starting recovery and reuse the initial queue drain; avoid creating sessions just to clear absent queues. Validation: 1228 tests passed across six lifecycle suites; make static-check passed. Production ledger: +52/-50 (net +2); the lower PR remains neutral against its prior -2 ledger.
Fail closed on preference I/O errors, retry boundedly, and discard rejected load caches without losing owed Stop markers or unknown opt-out state. Cancel only captured durable guidance IDs during stop settlement and contain each startup normalization failure independently. Consolidate preference defaulting and replace manual startup-tail scanning with findLast using identical predicates. Validation: 1810 tests passed across 38 lifecycle/session files, including tail/goal/compaction; make static-check passed. Production ledger: +72/-72, net zero.
Reuse initial shimmer and cached transcript rendering without a spinner lane or permanent padding. Validate stable catch-up geometry and a viewport-fitting initial phone skeleton. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$152.14`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=152.14 -->
Overlay the existing dock edge with accessible shimmer feedback during cached replay, preserving transcript clearance and active-barrier priority. Replace source-syntax viewport assertions with composed metadata and measured phone layout checks. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$21.52`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=21.52 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Record the user preference to use `gh stack` for GitHub-native stacked PRs, keeping every PR linked in the native stack rather than only chaining base branches. `AGENTS.md` points to `docs/AGENTS.md`; the generated built-in skill copy is synchronized. ## Stack Fourth PR in native stack #4174, directly above #4194: #4172 → #4173 → #4194 → this PR. Stack membership is managed with `gh stack link`. ## Validation - Formatting checked against the resolved `AGENTS.md` target. - `make static-check` and `git diff --check`. - No prose-only assertion tests added. ## Subtractive ledger Production logic: +0 / −0. One documentation line and its generated string mirror; no behavior changes or unrelated subtractions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$459.97`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=459.97 -->
ammar-agent
force-pushed
the
fix-chat-loading-gap
branch
from
September 9, 2026 17:49
093f537 to
a9c31ef
Compare
Collaborator
Author
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Collaborator
Author
|
Code and security review now both approve a9c31ef with no findings. The six earlier missing-ref service errors are superseded by these successful reviews and are being marked outdated. Remaining failed test/static jobs stopped during Chrome apt repository setup; current package hashes now match, and local full static checks plus targeted regressions passed, so those jobs will be retried unchanged. |
ammario
pushed a commit
that referenced
this pull request
Sep 9, 2026
## Summary Keep stopped sub-agents stopped across application restart and chat replay, preventing false startup activity and local-concurrency warning flashes. This is the lower PR in a stack; #4173 contains the loading-UI cleanup. ## Implementation - Reuse the initialization metadata snapshot through identity admission and retry derivation rather than repeatedly scanning all workspaces. - Probe through shared transient-session ownership, retaining only real activity or adopted sessions; deferred disposal preserves physical I/O leases without holding startup open. - Restore question-blocked guidance per ID into the existing queue without dispatching a stream, preserving dispatch mode and deduplicating against live queued guidance. Applicable Stop/opt-out blockers still win. Live and replayed guidance share acceptance, cancellation, failure cleanup, and background stream handoff. - Preference I/O failures retry without manufacturing enabled defaults or poisoning the load cache; newly owed Stop markers survive a failed initial read. Stop settlement cancels only captured guidance IDs, and each normalization contains returned/thrown failures. - Before admitting queued work, normalize durably stopped/opted-out inactive children through the existing task-stop lifecycle so they release parallel capacity. Question/read-failure blockers keep their slots; active streams/preparations and live pause semantics remain unchanged. Nested drain wakes stay suppressed until normalization is complete. - Give TaskService sole ownership of child startup recovery. Generic chat replay cannot recover children or unknown workspace identities. - Honor persisted Stop markers, retry opt-outs, and unanswered questions before restart nudges or completion prompts, including legacy statusless tasks. Scoped Stops remain authoritative until history establishes newer accepted user/delegated intent. Live pause/resume and live retry semantics are unchanged. - Use strict partial reads for startup admission and reuse bounded, cancellable startup read retries for transient failures; malformed JSON and schema-invalid partials are ignored rather than retried forever, and other HistoryService callers retain their lenient behavior. - Classify admission as stopped, blocked, waiting for a question, interrupted, or idle in one read. Legacy statusless children need an interrupted tail only for a generic nudge; durable compaction and queued guidance keep priority. - Bound each complete admission probe, including preference loading, with a cancellable deadline. Timeouts fail closed for that task while startup proceeds; physical read leases stay attached until actual I/O settles. - Keep disk-read retry delays independent of provider idleness and refresh candidate identities/statuses after asynchronous inspections and at each task dispatch, preventing startup stalls or rerunning tasks that just completed. - Normalize inactive-workflow children before filtering recovery blockers, so cancelled tasks cannot retain active status and consume capacity. - Recover compaction follow-ups with durable acceptance awaited but provider execution handed to the existing background path, before generic restart prompts or queued parent guidance, then queue that guidance without losing either payload; contain read/send failures per task instead of aborting app startup. - Remove obsolete child-specific startup precedence and duplicate history/error/model-normalization logic. ## Validation - All 2,381 service/history/startup tests pass across 51 files (~31s); local `make static-check` passes. - Regressions cover stopped task statuses, scoped/unscoped/stale markers, long/unreadable history, real transient and persistent partial-file failures, pending questions, missing identity, inactive workflows, genuine crash recovery, and compaction continuation precedence. - Existing virtual-clock coverage verifies bounded retries, recovery-stage checkpoints, shutdown drainage, and manual-successor safety. ## Subtractive ledger **P1: 553 production lines added, 556 removed; net −3.** Removed the duplicate child recovery path and child-only option precedence, shared the existing read-retry loop and interrupted-tail predicate, reused existing error/model/agent-ID normalization, and shared read plumbing, send settings, and log context without dropping diagnostics; shared per-ID guidance settlement replaces duplicated batch/live cleanup. These retain safety checks while reducing competing recovery paths; no new persisted state. Tests are excluded. ## Risks Startup ownership changes across chat replay and task reconciliation. Admission conservatively preserves Stop/question state when disk reads remain unavailable; explicit resume and live retry remain covered by the service suites. ## Pains Review exposed legacy task states and workflow/recovery interactions, requiring additional disk-backed regressions. Existing retry timing is virtualized in persistent-error tests to keep validation deterministic. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$406.76`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=406.76 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 19 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +100 / −49 (net +51), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammario
pushed a commit
that referenced
this pull request
Sep 9, 2026
## Stack Third PR, stacked on #4173 (`fix-chat-loading-gap`), which is stacked on #4172. Merge bottom-up; this diff contains only the concurrency-warning change. ## Summary Replace changing agent names with a stable compact count: **“N other local agents running — may interfere.”** Agent activity handoffs previously switched the selected name and caused random-looking flashes. Names no longer participate in warning rendering. ## Implementation - Subscribe to the active count instead of the first active workspace identity. - Preserve existing brief handoff protection, same-family suppression, and project/runtime isolation rules. Scope the held count to sorted eligible workspace IDs so reordering is harmless and eligibility changes clear stale warnings. - Keep the single-row composer decoration and use tabular numerals for stable count typography. No new timers, effects, animations, or tooltips. - Cover multi-agent handoffs and metadata reordering, with desktop and explicitly pinned phone stories. ## Validation - All 47 warning/Storybook contract tests pass, including 10 warning handoff/filtering cases. - Three Chromium Storybook renders pass: single-agent desktop, multiple-agent desktop, and fixed-390px phone. Phone checks cover overflow, tabular numerals, and composer clearance. - `make static-check` passes on the integrated three-PR stack. ## Subtractive ledger **P1: 27 production lines added, 33 removed; net −6.** Removed selected-agent/name resolution and simplified the ChatPane interface. The existing eligibility and handoff safeguards remain. Tests/stories are excluded; no unrelated offsets. ## Risks The warning now reports quantity rather than identity, including for one other agent. Counts change only with activity/eligibility, not with whichever agent happens to appear first. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$436.55`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=436.55 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Record the user preference to use `gh stack` for GitHub-native stacked PRs, keeping every PR linked in the native stack rather than only chaining base branches. `AGENTS.md` points to `docs/AGENTS.md`; the generated built-in skill copy is synchronized. ## Stack Fourth PR in native stack #4174, directly above #4194: #4172 → #4173 → #4194 → this PR. Stack membership is managed with `gh stack link`. ## Validation - Formatting checked against the resolved `AGENTS.md` target. - `make static-check` and `git diff --check`. - No prose-only assertion tests added. ## Subtractive ledger Production logic: +0 / −0. One documentation line and its generated string mirror; no behavior changes or unrelated subtractions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$459.97`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=459.97 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 19 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +100 / −49 (net +51), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammario
pushed a commit
that referenced
this pull request
Sep 10, 2026
…4196) ## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Only remaining open PR in native stack #4174, now based on main after #4172, #4173, and #4194 merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Stacked on #4172 (
fix-stopped-task-startup). Merge the startup fix first, then retarget this PR tomain. This diff contains only the loading UI cleanup.Summary
Remove the permanent transcript gutter reserved for the transient “Loading messages…” badge. Initial uncached history keeps the existing Vercel-style shimmer skeleton; cached replay keeps real rows visible and shows an accessible shared shimmer strip over the existing dock edge without occupying transcript space.
Implementation
Validation
make static-checkpasses on the integrated stack.Subtractive ledger
P1: 20 production lines added, 23 removed; net −3. Removed the separate loading badge and the permanent gutter it required, reusing shared shimmer for an accessible overlay confined to the existing dock edge. No unrelated offsets.
Risks
Removing reserved padding changes settled transcript geometry intentionally. Regression checks protect bottom anchoring, cached catch-up stability, and narrow-screen composer visibility.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:xhigh• Cost:$236.73