Drop redundant factory_bot_rails dependency - #67
Merged
Merged
Conversation
pageflow-support already depends on factory_bot_rails. Pinning a version here as well made the bundle unresolvable against the pageflow edge branch, which requires ~> 6.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pageflow-supportalready depends onfactory_bot_rails, so pinning aversion here as well means both constraints have to agree. Pageflow master
moved pageflow-support to
~> 6.5while this gemspec asks for~> 4.8,which leaves the bundle unresolvable in the CI job that runs against the
pageflow edge branch.
Dropping the pin lets pageflow-support decide:
factory_bot_rails 4.11.1against the released gem,
6.5.1against edge.Verified against pageflow master on Rails 8.1.3.1: 63 examples, 0 failures.