Support Rails 8.0 and 8.1 - #2485
Merged
Merged
Conversation
Active Support freezes the options it passes to as_json since Rails 8, so extending the caller's hash raised FrozenError when Active Admin rendered JSON downloads.
Rails 8 dropped support for passing the result of caller to ActiveSupport::Deprecation#warn. Pageflow::Deprecation.warn already falls back to caller_locations of the very same frame.
Rails 8.1 raises on increment! for new records. Revision components can be saved while their entry still is, since the before_save callback that assigns the perma id is registered ahead of the belongs_to autosave.
Rails 8 only loads routes on demand while eager loading is off, so the Active Admin controller constants that controller specs name were missing as soon as the spec files were loaded.
Rails 8 exits when asked for a generator that does not exist, which aborted dummy app generation for engines like pageflow_paged.
Earlier versions restrict Active Job to < 8.
Move the supported range to >= 7.2, < 8.2 and derive the gemspec requirement from it. Outside that range PAGEFLOW_RAILS_VERSION now drops the rails constraint entirely, so both older and newer versions can still be tried out. CI covers both ends of the range.
Pageflow does not use Active Storage. Rails 8.1 raises while loading it when the ruby-vips gem is present but libvips is older than 8.13, since it cannot disable libvips' unfuzzed operations in that case. Pageflow depends on ruby-vips for its own webp processor, so dummy app generation aborted on CI test images shipping an older libvips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.