Pin json below 3 - #2486
Merged
Merged
Conversation
json 3 made JSON.parse options keyword-only and dropped quirks_mode. Every Rails version we support still relies on one or the other: 8.1 passes its options hash positionally, 7.2 passes quirks_mode. Either way ActiveSupport::JSON.decode raises, so reading any serialized JSON column fails. Rails has fixed this on 8-0-stable and 8-1-stable, but not on 7-2-stable and not in any released version yet. Plugins inherit the constraint through their pageflow dependency, so this is the only place to unpin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json 3 made JSON.parse options keyword-only and dropped quirks_mode. Every Rails version we support still relies on one or the other: 8.1 passes its options hash positionally, 7.2 passes quirks_mode. Either way ActiveSupport::JSON.decode raises, so reading any serialized JSON column fails. Rails has fixed this on 8-0-stable and 8-1-stable, but not on 7-2-stable and not in any released version yet.
Plugins inherit the constraint through their pageflow dependency, so this is the only place to unpin.