Add optional parallel eager loading - #339
Open
elpete wants to merge 29 commits into
Open
Conversation
elpete
force-pushed
the
feat/55-parallel-eager-loading
branch
3 times, most recently
from
August 26, 2026 15:12
b7ceb98 to
6847a98
Compare
elpete
force-pushed
the
feat/55-parallel-eager-loading
branch
from
August 27, 2026 00:06
6847a98 to
26c7041
Compare
elpete
force-pushed
the
feat/55-parallel-eager-loading
branch
from
August 27, 2026 00:39
b374abd to
43b17d0
Compare
elpete
force-pushed
the
feat/55-parallel-eager-loading
branch
from
August 27, 2026 00:39
43b17d0 to
6bec058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Issue review
Recommendation: 7/10 — implement as opt-in. Independent eager-load branches can benefit from concurrency when database latency and hydration work dominate, especially for several unrelated top-level relationships. It should not be the default: concurrency consumes more database connections and CPU, and does not help a single relationship or necessarily improve low-latency queries.
Implementation
parallelboolean towith, e.g..with( [ "author", "comments" ], true )parallelEagerLoadingExecutor, otherwise Quick creates and owns a fixed executorparallelEagerLoadingMaxThreadsby the configured executor's maximum pool sizequickRelationshipLoaded, on the calling threadValidation
box run-script format:checkgit diff --checkUses
qb@14.0.0-beta.3.