Skip to content

fix: harden options and Release Please patch flow #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tensornull merged 3 commits into from
Jul 29, 2026
Merged

fix: harden options and Release Please patch flow #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ee0fdf
fix: snapshot supported client options once
tensornull Jul 29, 2026
a33c128
fix: harden Release Please patch releases
tensornull Jul 29, 2026
4ffee49
fix: recover exact Release Please runs
tensornull Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
outputs:
artifact-name: ${{ steps.artifact-name.outputs.name }}
dist-tag: ${{ steps.version.outputs.dist-tag }}
release-commit: ${{ steps.trust.outputs.release-commit }}
release-tag: ${{ steps.trust.outputs.release-tag }}
Expand Down Expand Up @@ -156,10 +157,18 @@ jobs:
RELEASE_JSON="$release_json" TAG_COMMIT="$tag_commit" \
node --input-type=module <<'EOF'
import { readFileSync } from "node:fs";
import { validateGitHubRelease } from "./scripts/release-workflow-validation.mjs";
import {
extractReleaseNotesFromChangelog,
validateGitHubRelease,
} from "./scripts/release-workflow-validation.mjs";

const release = JSON.parse(readFileSync(process.env.RELEASE_JSON, "utf8"));
const version = JSON.parse(readFileSync("package.json", "utf8")).version;
validateGitHubRelease(release, {
expectedBody: extractReleaseNotesFromChangelog(
readFileSync("CHANGELOG.md", "utf8"),
version,
),
htmlUrl: process.env.RELEASE_HTML_URL,
releaseCommit: process.env.RELEASE_COMMIT,
tag: process.env.RELEASE_TAG,
Expand Down Expand Up @@ -202,10 +211,16 @@ jobs:
--tag "${{ steps.trust.outputs.release-tag }}"
npm run test:examples -- --tarball "${{ steps.pack.outputs.tarball }}"
npm run test:fixtures -- --tarball "${{ steps.pack.outputs.tarball }}"
- name: Name the attempt-qualified release artifact
id: artifact-name
shell: bash
run: |
set -euo pipefail
echo "name=npm-package-${{ steps.version.outputs.version }}-${{ github.run_id }}-${{ github.run_attempt }}" >> "$GITHUB_OUTPUT"
- name: Upload the verified release artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: npm-package-${{ steps.version.outputs.version }}
name: ${{ steps.artifact-name.outputs.name }}
path: ${{ steps.pack.outputs.tarball }}
if-no-files-found: error
retention-days: 30
Expand Down Expand Up @@ -280,7 +295,7 @@ jobs:
- name: Download the verified release artifact
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: npm-package-${{ needs.verify.outputs.version }}
name: ${{ needs.verify.outputs.artifact-name }}
path: release-artifacts
- name: Publish the exact artifact with provenance
env:
Expand Down
Loading