fix: isolate release PR transport retries - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Release Please run 30509764960 failed with
other side closedafter candidate generation and before any remote write. The pinned v5 action uses Node global fetch through Octokit; an isolated Undici closed-connection race can fail the Git commit read used by PR maintenance, and that path has no transport retry.Retrying the former combined action was unsafe because the same invocation could also create an immutable tag and GitHub Release. The workflow now runs release creation separately with
skip-github-pull-request: trueand never retries it. Only the idempotent PR path usesskip-github-release: true, with one retry gated on the first step's failure outcome.Validation
RELEASE_PLEASE_ENABLEDandLIVE_SMOKE_ENABLEDremain disabled. This PR creates no tag, GitHub Release, live request, or registry state.