Give the link check a longer timeout and retries - #52
Merged
Conversation
Master went red on lijunsun.github.io/files/ScientificWritingV39.pdf, which returns 200 from a normal network and resolves to GitHub Pages. It is a large PDF, so the default 10s timeout is the likely cause rather than a block. Raising the timeout to 20s with three retries covers that class of failure without another blanket exemption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master is red on
lijunsun.github.io/files/ScientificWritingV39.pdf. That link returns 200 from a normal network on three consecutive attempts, and the host resolves to GitHub Pages, so it is not dead. It is a large PDF, which points at the default 10s timeout rather than an IP block.Adds
timeout: 20s,retryCount: 3,retryOn429, and a fallback delay. That covers slow responses without adding another host to the ignore list.Context
Since
0was removed fromaliveStatusCodes, the check has flagged four links that are all actually alive:Worth being honest that this is upkeep. The strict setting earned its keep once by catching three genuinely dead links, including an NXDOMAIN host that the old config reported as healthy. Whether it keeps earning it depends on how often false positives show up from here.
If they keep coming, the alternative is restoring
0toaliveStatusCodes— CI goes quiet and stable, but a disappearing domain will no longer be caught, and periodic manual sweeps become the way to find them.