feat: make Waypoints behave like a list (fixes #430) - #477
Open
ChickenisLegit wants to merge 2 commits into
Open
feat: make Waypoints behave like a list (fixes #430)#477ChickenisLegit wants to merge 2 commits into
ChickenisLegit wants to merge 2 commits into
Conversation
Member
|
@ChickenisLegit thanks for the contribution!!! 🌟 Could you please add a bullet point in the changelog file describing the change and a little unit test for the feature? |
Author
|
@gonzalocasas Done! Added the changelog entry and the unit tests. |
Contributor
|
Hi @ChickenisLegit thanks for the contribution. Look good to me. Just a stylistic suggestion, would you consider moving the implementation of the You can choose to merge as is or choose to move it and merge. |
yck011522
approved these changes
Aug 10, 2026
Member
|
@yck011522 very good point! @ChickenisLegit could you please move it to the subclasses and then we can merge? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430. Added list-like methods to the Waypoints base class so that FrameWaypoints and PointAxisWaypoints can be iterated, indexed, appended to, etc.