Skip to content

Fixes the mesh shading - #10

Merged
ericgozzi merged 5 commits into
mainfrom
mesh_shading
Apr 8, 2026
Merged

Fixes the mesh shading#10
ericgozzi merged 5 commits into
mainfrom
mesh_shading

Conversation

@ericgozzi

@ericgozzi ericgozzi commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes the shading of meshes with sharp edges. The sharp edge crease is set to 30degrees.

Also add a Github action that builds and commits a the static assetes

@ericgozzi
ericgozzi requested review from josemmo and nbbosco April 7, 2026 14:48
Comment thread .github/workflows/build_and_commit.yml Outdated
@ericgozzi
ericgozzi requested a review from josemmo April 8, 2026 07:02

@josemmo josemmo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! An extra commit on each PR shouldn't be too much.

Comment thread .github/workflows/build_and_commit.yml Outdated
Comment thread .github/workflows/build_and_commit.yml Outdated
Comment thread .github/workflows/build_and_commit.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@ericgozzi

ericgozzi commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator Author

Amazing! Thank's a lot @josemmo

@ericgozzi
ericgozzi merged commit c8c2462 into main Apr 8, 2026
1 check passed
@ericgozzi
ericgozzi deleted the mesh_shading branch April 8, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants