Skip to content

Cache key fix - #43

Merged
kp-cat merged 2 commits into
masterfrom
cache_key-fix
Sep 16, 2026
Merged

kp-cat merged 2 commits into
masterfrom
cache_key-fix

Conversation

@kp-cat

@kp-cat kp-cat commented Sep 16, 2026

Copy link
Copy Markdown
Member

Describe the purpose of your pull request

  • Fix sdk_key parameter passing in ConfigService used for cache_key calculation.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@kp-cat
kp-cat requested a review from a team as a code owner September 16, 2026 16:07
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.52%. Comparing base (38e5209) to head (6ebd079).

Files with missing lines Patch % Lines
lib/configcat/version.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          40       40           
  Lines        3314     3324   +10     
=======================================
+ Hits         3265     3275   +10     
  Misses         49       49           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kp-cat
kp-cat merged commit 7ebc128 into master Sep 16, 2026
22 of 24 checks passed
@kp-cat
kp-cat deleted the cache_key-fix branch September 16, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants