-
Notifications
You must be signed in to change notification settings - Fork 60
Update docker.io/library/golang Docker tag to v1.26.7 (main) #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| ## Build | ||
|
|
||
| FROM docker.io/library/golang:1.26.3@sha256:2d6c80227255c3112a4d08e67ba98e58efd3846daf15d9d7d4c389565d881b1a AS build | ||
| FROM docker.io/library/golang:1.26.7@sha256:45a5f7a810238aabcbad211d70b9ae082022d96f7c7259e94041ad1b933575ac AS build | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] metadata inconsistency The PR title says 'Update ... to v1.26.4' but the actual diff bumps the image from golang:1.26.3 to golang:1.26.5, skipping 1.26.4 entirely. The PR body mentions '1.26.3 to 1.26.4, Pending: 1.26.5', confirming the title is stale relative to the committed change. This is a cosmetic mismatch typical of Renovate bot rebases but could cause confusion when triaging or auditing dependency updates. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] metadata inconsistency The PR title references v1.26.4, but the actual diff updates the golang image from 1.26.3 to 1.26.5. The PR body lists the change as 1.26.3 β 1.26.4 with 1.26.5 as pending, yet the committed code already uses 1.26.5. This is likely due to Renovate rebasing onto a newer version after the PR was initially created. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] protected-path This PR modifies Dockerfile, which is a protected governance/infrastructure path. The PR has no linked issue providing authorization for the change. Human approval is required for all changes to protected paths. Suggested fix: Ensure a human reviewer approves changes to the Dockerfile. Consider linking to an issue that authorizes this infrastructure change. |
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] protected-path
This PR modifies the Dockerfile, which is a protected governance/infrastructure file. The PR has no linked issue providing authorization for this change. While the PR description explains this is a Renovate-managed dependency update (golang 1.26.3 β 1.26.7), human approval is required for any modification to protected paths.
Suggested fix: A human reviewer must explicitly approve this change to a protected path.