chore: Pre-commit hooks - #2
Open
gcgoncalves wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
gcgoncalves
force-pushed
the
pre-commit
branch
from
August 10, 2026 14:46
1afa140 to
ce1668b
Compare
marekdano
reviewed
Aug 10, 2026
There was a problem hiding this comment.
Suggestions (non-blocking)
- The hook is heavy for a pre-commit:
format:check+lint(whole
src+e2e) + fullbuild+ fullvitest run. That's likely tens of seconds
to minutes on every commit, which tends to push people toward
git commit --no-verify. Common pattern: runlint-staged(prettier/eslint on
staged files only) at pre-commit, and movebuild+ the full test suite to a
pre-push hook or rely on CI. That keeps commits fast while still gating
pushes. - Stale comment in
eslint.config.js: it warns about "a
second, differently-configuredprettier.config.jsone directory up (repo
root)." That referred to the old monorepo layout; there's no such file in this
standalone repo. Now that.prettierrcis added, that comment is misleading
and could be trimmed. Pre-existing, so optional.
Contributor
Author
|
Great point, @marekdano! I'll update accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prettier, eslint and unit tests to the pre-commit hook.