Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
2 similar comments
|
I have read the CLA Document and I hereby sign the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
1ce1c26 to
da297d7
Compare
|
I have read the CLA Document and I hereby sign the CLA |
da297d7 to
e20bdb3
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
Maintainer: infra-flaky fails (jetbrains-tests, vscode-get-test-file-matrix) need rerun. |
|
Update on the CI failures (commit 8686): CLI PR Checks ✅, VSIX build ✅, CLA ✅. The only red job is |
Problem
OpenAI streamed tool-call deltas carry a stable
index, whileidis optional on continuation fragments. Continue'sfromChatCompletionChunk()droppedtool_call.index, andapplyToolCallDelta()fell back to updating the most recently tracked tool call whenever a fragment had noid. With two parallel tool calls whose argument fragments interleave, one call's arguments were applied to the other call.Fixes #13223.
Solution
tool_call.indexthroughToolCallDelta(new optionalindex?: numberon the type + converter passthrough).applyToolCallDelta(), when a delta has noidbut has anindex, match the existing tool-call state by stream position instead of "last array element".Impact
Evidence
core/llm/openaiTypeConverters.test.tsassertingindexsurvivesfromChatCompletionChunk().npm installin this sandbox failed on /tmp disk quota (chromium-bidi tar write), so the repo vitest suite could not run here; test added for CI.Fixes #13223