Conversation
…2699) Spawn tool shells in their own process group, resolve the tool call on process exit (after a short stdio flush) instead of waiting for close, and kill the full process group on timeout/cancel. Background jobs use the same spawn/kill behavior. Adds regression tests for background and detached child cases.
Author
|
I have read the CLA Document and I hereby sign the CLA |
TS18047: child.stdout/stderr are typed as nullable; use optional chaining when attaching and removing data listeners (matches BackgroundJobService and other spawn call sites).
Place processTree import with other ../util imports after cli.js so eslint import/order passes.
Avoid empty Vitest suites on Windows while preserving the Unix regression coverage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12699.
When a Bash tool command backgrounds or detaches a child that keeps inherited stdio open, Node's
closeevent never fires and the CLI tool call hangs. This change:detached: true(own process group)closeprocess.kill(-pid))BackgroundJobServiceTesting
vitest run src/tools/runTerminalCommand.test.ts(9 passed, including Continue hangs after background or detached child-process tool calls #12699 cases)