Conversation
|
Thanks — the intent is right (the unit is not written down anywhere a reader of the schema would find it), but I am going to decline this shape rather than merge it, for two reasons. Applied migrations are history. SQLite stores the CREATE statement text verbatim in The unit is not uniform enough to assert blanket. We audited several If you want to carry this forward, the shape that would merge: a short table in the storage section of |
|
Reshaped per maintainer feedback: timestamp units table (epoch ms, per-column verified writers) added to ARCHITECTURE.md, and |
created_at uses Date.now() (epoch ms), but schema has no unit comment. This PR adds
-- epoch ms (Date.now())comments to all created_at columns for clarity.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds
-- epoch ms (Date.now())comments to allcreated_atcolumns in the schema to document the timestamp unit, with no behavior change.Written for commit 6e3751e. Summary will update on new commits.
Greptile Summary
This PR documents the unit used by
created_atcolumns in the migration and database-initialization schemas.Confidence Score: 5/5
The PR appears safe to merge because it only adds valid SQL comments and introduces no behavioral changes.
The added comments preserve SQL parsing, match the timestamp unit used by current production writers, and do not change database schemas or data paths.
Important Files Changed
Reviews (1): Last reviewed commit: "docs: add epoch ms unit comment to creat..." | Re-trigger Greptile