fix(form): validate conflicting field options - #658
Open
oxura wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294.
Form fields currently accept contradictory custom options and only complain later while cleaning a submitted value. That makes an invalid field definition look healthy until a request happens to exercise it.
This moves the invariant to field construction. Text length ranges, numeric ranges, and date/time ranges now reject min > max from
FormField::with_options, while equal bounds and unconstrained fields keep working as before. The shared field macro calls a small internal validation trait, so each field family owns its option invariant without duplicating construction logic.I also replaced the old delayed email-validation test and added construction-time coverage for every constrained field family.
Checked with:
cargo test -p cot --all-features form::fields(113 passed)cargo clippy -p cot --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --check