chore(deps): fix Dependabot groups so dev/docs deps update in one PR - #479
Conversation
The `dev` group never applied to version updates: GitHub kept the `applies-to: security-updates` value set in #345 after #353 removed the key, so weekly jobs only carried the `org` group and every dev/docs bump became an individual PR. - set `applies-to: version-updates` explicitly on `org` and `dev` - drop `update-types` so patch bumps join the group too - match `org` packages exactly instead of `*` + exclude-patterns (`markdown-gfm-admonition` was landing in `org`) - add a `security` group so security fixes stay grouped
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe Dependabot configuration separates version updates for organization packages and development packages. It also adds a group for security updates. ChangesDependabot grouping
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only adjusts Dependabot grouping behavior and is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hopefully this change could work as expected |
2bndy5
left a comment
There was a problem hiding this comment.
🤞
Here's hoping those dependabot bugs were fixed...
Why
Dependabot keeps opening one PR per dev dependency (currently #474 for mypy and #478 for ruff) although
dependabot.ymldefines adevgroup.Root cause, taken from the Dependabot job logs (Insights → Dependency graph → Dependabot → uv.lock):
orggroup (Found 1 group(s)). Thedevgroup is absent from the job definition.dev, with"applies-to": "security-updates".applies-to#345 setapplies-to: security-updatesondev; chore: group dependency updates with exclude-patterns #353 removed the key, but GitHub kept the old value while refreshing the other rules.orgwas a new group name in chore: group dependency updates with exclude-patterns #353, so it got the default.Two smaller issues fixed on the way:
update-types: [major, minor]would have excluded patch bumps from the group anyway. dependabot-core opens an individual PR for any level not listed, which is exactly the chore(deps-dev): bump mypy from 2.3.0 to 2.3.1 #474/chore(deps-dev): bump ruff from 0.16.2 to 0.16.6 #478 case.orgused*plusexclude-patterns, somarkdown-gfm-admonitionwas being assigned to theorggroup (visible in the logs).What changed
org: explicitapplies-to: version-updates, exact patternsclang-toolsandcpp-linter.dev: explicitapplies-to: version-updates, noupdate-types, so major/minor/patch bumps of everything else land in one PR.securitygroup (applies-to: security-updates,*) so security fixes stay grouped. Until now that only happened by accident. Drop it if individual security PRs are preferred.How to verify
Merging triggers a uv job right away. Its log should say
Found 2 group(s)and Dependabot should open a single "bump the dev group with N updates" PR; #474 and #478 then get superseded.Fallback: if the log still reports one group, rename
dev. GitHub appears to key the stale value on the group name, so a new name starts clean.Summary by CodeRabbit