feat: support LLVM 23 - #481
Conversation
Add 23 to the accepted `version` values and to the self-test matrix. The install paths are already in place upstream: clang-tools 1.3.0 (on main since #477) raises MAX_VERSION to 23 and points at the static binary release that ships the 23 builds, apt.llvm.org knows the `-23` pattern, and Homebrew aliases `llvm@23` to the current `llvm` formula (23.1.1), so no change to the installation steps is needed. The default `version` stays at 21.
Cpp-Linter Report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughChangesClang 23 support
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR adds LLVM 23 to the accepted versions and self-test matrix without changing installation behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Maybe support LLVM 23 first to release a minor release, then move to auto-fix as a minor release if it works as expected. |
Adds
23to the acceptedversionvalues and to the self-test matrix, now that clang-tools-static-binaries ships the LLVM 23 builds.Changes
action.yml—23added to the acceptedversionvalues.github/workflows/self-test.yml—'23'added to theclang-versionmatrixThat is the whole diff. No change to the installation steps was needed, because every path already resolves 23:
clang-tools(fallback, all platforms)MAX_VERSIONto 23 and pins the2026.09.01-5fb8802dbinary release that carries the 23 builds. Already onmainvia #477.llvm.shcarriesLLVM_VERSION_PATTERNS[23]="-23".llvm@23is an alias of the currentllvmformula (23.1.1), sobrew install llvm@23resolves.Verification
Installed and ran the tools through the dependency set this repo locks:
mkdocs buildregenerates the inputs doc with the updated list, and both YAML files parse.Note for review
The default
versionstays at 21 — bumping it is a separate call, so I left it out. Historically it has trailed the newest release by one or two (18 → 20 when 22 landed in #398, then 20 → 21 in #458). Happy to bump it to 22 here if you'd rather keep that cadence.The matrix now runs 12 through 23 (12 versions × 3 OS). Earlier releases dropped the oldest entry when adding a new one (#398 dropped 9 and 10, #458 dropped 11), but
clang-toolsstill declaresMIN_VERSION = 12, so nothing is forced out yet.Summary by CodeRabbit