Skip to content

feat: support LLVM 23 - #481

Merged
shenxianpeng merged 1 commit into
mainfrom
feature/llvm-23
Sep 13, 2026
Merged

shenxianpeng merged 1 commit into
mainfrom
feature/llvm-23

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Sep 13, 2026

Copy link
Copy Markdown
Member

Adds 23 to the accepted version values and to the self-test matrix, now that clang-tools-static-binaries ships the LLVM 23 builds.

Changes

  • action.yml23 added to the accepted version values
  • .github/workflows/self-test.yml'23' added to the clang-version matrix

That is the whole diff. No change to the installation steps was needed, because every path already resolves 23:

Path Status
clang-tools (fallback, all platforms) 1.3.0 raises MAX_VERSION to 23 and pins the 2026.09.01-5fb8802d binary release that carries the 23 builds. Already on main via #477.
apt.llvm.org (Linux) llvm.sh carries LLVM_VERSION_PATTERNS[23]="-23".
Homebrew (macOS) llvm@23 is an alias of the current llvm formula (23.1.1), so brew install llvm@23 resolves.

Verification

Installed and ran the tools through the dependency set this repo locks:

$ uv run --group action clang-tools install clang-format clang-tidy --version 23
Downloading clang-format (version 23)
Installing clang-format-23 to ...
Downloading clang-tidy (version 23)
Installing clang-tidy-23 to ...

$ ./clang-format-23 --version
clang-format version 23.1.0

$ ./clang-tidy-23 --version
LLVM version 23.1.0

mkdocs build regenerates the inputs doc with the updated list, and both YAML files parse.

Note for review

The default version stays at 21 — bumping it is a separate call, so I left it out. Historically it has trailed the newest release by one or two (18 → 20 when 22 landed in #398, then 20 → 21 in #458). Happy to bump it to 22 here if you'd rather keep that cadence.

The matrix now runs 12 through 23 (12 versions × 3 OS). Earlier releases dropped the oldest entry when adding a new one (#398 dropped 9 and 10, #458 dropped 11), but clang-tools still declares MIN_VERSION = 12, so nothing is forced out yet.

Summary by CodeRabbit

  • New Features
    • Added support for Clang Tools version 23.
    • Updated the version input guidance to include version 23.
  • Tests
    • Extended automated testing to cover Clang Tools version 23.

Add 23 to the accepted `version` values and to the self-test matrix.

The install paths are already in place upstream: clang-tools 1.3.0 (on
main since #477) raises MAX_VERSION to 23 and points at the static binary
release that ships the 23 builds, apt.llvm.org knows the `-23` pattern,
and Homebrew aliases `llvm@23` to the current `llvm` formula (23.1.1), so
no change to the installation steps is needed.

The default `version` stays at 21.
@shenxianpeng
shenxianpeng requested a review from a team as a code owner September 13, 2026 18:03
@shenxianpeng
shenxianpeng requested review from 2bndy5 and removed request for a team September 13, 2026 18:03
@github-actions github-actions Bot added the enhancement New feature or request label Sep 13, 2026
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.hpp
  • docs/examples/demo/demo.cpp
clang-tidy (v16.0.6) reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 69b22a87-5470-4896-bf2d-f9ba758ef816

📥 Commits

Reviewing files that changed from the base of the PR and between 32e4c65 and 375609b.

📒 Files selected for processing (2)
  • .github/workflows/self-test.yml
  • action.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

Changes

Clang 23 support

Layer / File(s) Summary
Version metadata and validation
.github/workflows/self-test.yml, action.yml
The self-test matrix adds clang version 23. The version input description lists 23 as an accepted clang-tools version.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 37560

The PR adds LLVM 23 to the accepted versions and self-test matrix without changing installation behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding LLVM 23 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shenxianpeng shenxianpeng added the minor A minor version bump label Sep 13, 2026
@shenxianpeng

Copy link
Copy Markdown
Member Author

Maybe support LLVM 23 first to release a minor release, then move to auto-fix as a minor release if it works as expected.

@shenxianpeng
shenxianpeng merged commit dacf512 into main Sep 13, 2026
44 checks passed
@shenxianpeng
shenxianpeng deleted the feature/llvm-23 branch September 13, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor A minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants