[6.x] Port General settings to Form - #19409
Merged
Merged
Conversation
riasvdv
changed the title
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 11, 2026 20:12
8f9566c to
f6b54a4
Compare
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 11, 2026 20:16
f6b54a4 to
aa479c9
Compare
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 11, 2026 20:24
aa479c9 to
19480df
Compare
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 11, 2026 20:27
19480df to
7b6e7fb
Compare
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 12, 2026 05:37
7b6e7fb to
28fbeab
Compare
riasvdv
marked this pull request as ready for review
August 12, 2026 05:38
Contributor
There was a problem hiding this comment.
Pull request overview
Ports General Settings to the shared Form system.
Changes:
- Builds and resolves the settings form server-side.
- Preserves read-only mode, notices, environment options, and validation.
- Updates tests and removes the dedicated Vue page.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Http/Controllers/Settings/GeneralSettingsController.php |
Defines and serves the Form payload. |
src/Cp/SelectOptions.php |
Refines boolean option return typing. |
resources/js/pages/settings/General.vue |
Removes the superseded page. |
tests/Feature/Http/Controllers/Settings/GeneralSettingsControllerTest.php |
Tests the Form payload and behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
riasvdv
force-pushed
the
t3code/form-general-settings
branch
from
August 12, 2026 07:18
28fbeab to
3190d47
Compare
brianjhanson
approved these changes
Aug 12, 2026
# Conflicts: # resources/js/pages/settings/General.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the General settings screen to the Form system.