[6.x] Port User settings to Form - #19418
Merged
Merged
Conversation
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 11, 2026 20:12
9319047 to
b7ea26b
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 11, 2026 20:12
44a0e3c to
473527e
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 11, 2026 20:17
b7ea26b to
8c1a5da
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 11, 2026 20:17
473527e to
e6ec9da
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 11, 2026 20:25
8c1a5da to
722153a
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 11, 2026 20:25
e6ec9da to
6066909
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 11, 2026 20:28
722153a to
56fd324
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 11, 2026 20:28
6066909 to
0be3c61
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 12, 2026 05:37
56fd324 to
79fc2d7
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 12, 2026 05:37
0be3c61 to
2c1d5ff
Compare
riasvdv
marked this pull request as ready for review
August 12, 2026 05:39
Contributor
There was a problem hiding this comment.
Pull request overview
Ports User Settings to the shared Form system with edition-aware controls and dynamic public-registration fields.
Changes:
- Adds a Form-backed view model and refresh endpoint.
- Migrates the Vue page to
FormPage. - Expands backend and frontend coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Http/ViewModels/UserSettingsViewModel.php |
Defines the User Settings form. |
src/Http/Controllers/Settings/Users/UserSettingsController.php |
Serves and refreshes form payloads. |
routes/cp.php |
Registers the refresh route. |
resources/js/pages/settings/users/Settings.vue |
Migrates the settings UI to FormPage. |
resources/js/pages/settings/users/Settings.test.ts |
Tests custom controls. |
resources/js/pages/Form.vue |
Supports configurable layout options. |
resources/js/pages/Form.test.ts |
Tests layout option forwarding. |
tests/Feature/Http/Controllers/Settings/UserSettingsControllerTest.php |
Tests form payloads, authorization, and refresh behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 12, 2026 07:18
2c1d5ff to
c51628a
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
2 times, most recently
from
August 12, 2026 07:38
8d4c6a8 to
48e33f0
Compare
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 12, 2026 07:38
c51628a to
ed8bed1
Compare
brianjhanson
approved these changes
Aug 12, 2026
riasvdv
force-pushed
the
t3code/form-user-settings
branch
from
August 12, 2026 16:34
ed8bed1 to
1f2d53a
Compare
riasvdv
force-pushed
the
t3code/form-section-settings
branch
from
August 12, 2026 16:34
48e33f0 to
1c460f0
Compare
brandonkelly
force-pushed
the
t3code/form-section-settings
branch
from
August 12, 2026 17:14
1c460f0 to
7224ce1
Compare
brandonkelly
force-pushed
the
t3code/form-user-settings
branch
from
August 12, 2026 17:14
1f2d53a to
e47dda4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the User settings screen to the Form system.