wlan: wmi: accept legacy GTK status event prefix - #22
Open
CeRRiLLo89 wants to merge 1 commit into
Open
Conversation
The GTK status parser requires the complete modern fixed parameter, although it only consumes the prefix through replay_counter. Validate both the event length and the TLV-declared length against the prefix actually consumed by the parser, while continuing to reject truncated events. Tested on raphael: - original kernel: at least 130 GTK length and extraction failures - patched kernel: zero GTK parser and extraction failures - Wi-Fi, suspend/WoW, push, mobile data, calls, KernelSU/SUSFS and rmnet_perf remained operational - no panic, Oops or module-signature failures ICNSS suspend_noirq -EAGAIN remains a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21 to the raphael-specific kernel branch actually consumed by the device tree.
The raphael dependency graph currently selects
android_kernel_xiaomi_sm8150:16.0-raphael, while #21 was merged only into generic16.0. The GTK parser in16.0-raphaeltherefore still contains the old full-struct length check.This applies the exact #21 change. The pre-patch file on
16.0-raphaelis byte-identical to the file at #21's original base, so this is a direct backport with no adaptation.Validation:
c90639a8c2bb123119e4011f96a0768368dc8debwas used for the 03/08 local full crDroid build with this patch integrated; build completed successfullyOriginal PR: #21