Skip to content

Fix max_lines parameter being overwritten in insert_into_temp_tables loop #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinv13 merged 1 commit into from
Jun 17, 2026
Merged

Fix max_lines parameter being overwritten in insert_into_temp_tables loop #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/xml2db/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,17 +388,16 @@ def insert_into_temp_tables(self, max_lines: int = -1) -> None:
for query, data in tb.get_insert_temp_records_statements(
self.data.get(tb.type_name, None)
):
if max_lines is None or max_lines < 0:
max_lines = len(data)
batch_size = len(data) if max_lines is None or max_lines < 0 else max_lines
start_idx = 0
while start_idx < len(data):
with self.model.engine.begin() as conn:
self.model.dialect.bulk_insert(
conn,
query.table,
data[start_idx : (start_idx + max_lines)],
data[start_idx : (start_idx + batch_size)],
)
start_idx = start_idx + max_lines
start_idx = start_idx + batch_size

def merge_into_target_tables(self, single_transaction: bool = True) -> int:
"""Merge data into target data model
Expand Down
Loading